Skip to content

fix/bind-workflow-registry-once#21856

Merged
mchain0 merged 4 commits intodevelopfrom
fix/bind-workflow-registry-once
Apr 7, 2026
Merged

fix/bind-workflow-registry-once#21856
mchain0 merged 4 commits intodevelopfrom
fix/bind-workflow-registry-once

Conversation

@mchain0
Copy link
Copy Markdown
Contributor

@mchain0 mchain0 commented Apr 3, 2026

bind workflow registry once and simplified shard client wiring

@mchain0 mchain0 requested review from a team as code owners April 3, 2026 10:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

👋 mchain0, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 3, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@mchain0 mchain0 enabled auto-merge April 3, 2026 11:01
skudasov
skudasov previously approved these changes Apr 3, 2026
bolekk
bolekk previously approved these changes Apr 6, 2026
Tofel
Tofel previously approved these changes Apr 7, 2026
@mchain0 mchain0 added skip-smoke-tests Skips E2E tests. Best for draft PRs to save on GitHub Runners. skip-e2e-regression Skips regression system tests labels Apr 7, 2026
@mchain0 mchain0 added this pull request to the merge queue Apr 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Apr 7, 2026
@mchain0 mchain0 dismissed stale reviews from Tofel, bolekk, and skudasov via 93ee367 April 7, 2026 09:57
@mchain0 mchain0 requested review from Tofel, bolekk and skudasov April 7, 2026 09:59
george-dorin
george-dorin previously approved these changes Apr 7, 2026
@mchain0 mchain0 enabled auto-merge April 7, 2026 10:07
george-dorin
george-dorin previously approved these changes Apr 7, 2026
@cl-sonarqube-production
Copy link
Copy Markdown

@mchain0 mchain0 requested a review from george-dorin April 7, 2026 12:32
@mchain0 mchain0 requested a review from Tofel April 7, 2026 12:33
@mchain0 mchain0 added this pull request to the merge queue Apr 7, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 7, 2026
@mchain0 mchain0 added this pull request to the merge queue Apr 7, 2026
Merged via the queue into develop with commit 79e8025 Apr 7, 2026
184 of 185 checks passed
@mchain0 mchain0 deleted the fix/bind-workflow-registry-once branch April 7, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-e2e-regression Skips regression system tests skip-smoke-tests Skips E2E tests. Best for draft PRs to save on GitHub Runners.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants